• Avery Musbach's avatar
    overview: Avoid bailing out of UpdateDragIndicatorsAndOverviewGrid · c7a9ef90
    Avery Musbach authored
    OverviewWindowDragController::UpdateDragIndicatorsAndOverviewGrid()
    contains code that bails out if the window cannot be snapped in split
    view. So then OverviewSession::RearrangeDuringDrag() does not get
    called, and it has responsibility for updating the drop target
    background visibility, hence Issue 964469. Also,
    OverviewSession::SetSplitViewDragIndicatorsIndicatorState() does not get
    called, and it has responsibility for reparenting the split view drag
    indicators widget so that it appears on the correct display, meaning
    that the present CL is a step toward fixing Issue 961171, although the
    present CL certainly does not completely fix Issue 961171.
    
    Test: manual
    Bug: 961171, 964469
    Change-Id: I95704caacfb315161c9ecf34e3ad55b1c40a8c2c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617272Reviewed-by: default avatarXiaoqian Dai <xdai@chromium.org>
    Commit-Queue: Avery Musbach <amusbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#661078}
    c7a9ef90
overview_window_drag_controller.cc 19.9 KB