• koz@chromium.org's avatar
    Revert 241162 "Make clicking the restart bubble for crashed apps..." · c7c0c92c
    koz@chromium.org authored
    This CL had the unintended side effect that Simulate Browser Restart no longer
    works. Also, experimentation suggests that the original bug it was intended to
    fix works without this change now.
    
    > Make clicking the restart bubble for crashed apps work.
    > 
    > Previously AppLoadService listened for
    > NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING before dispatching the
    > onRestarted() event after a reload, but in the case of packaged apps, which use
    > non-persistent background pages, that notification will never get fired. This
    > is because reloading an app doesn't cause its background page to get loaded -
    > only a relevant event causes the page to be woken up.
    > 
    > This patch fixes the issue by listening for NOTIFICATION_EXTENSION_LOADED
    > instead, which is always fired after a reload. It also determines whether an
    > extension is listening to an event by checking which events it has registered
    > for, not which ones it currently has a listener for,
    > NOTIFICATION_EXTENSION_LOADED is the notification that listeners get created
    > on, and so to avoid raciness we check registered events (ie: the persisted
    > list of events that an extension is interested in).
    > 
    > BUG=327964
    > 
    > Review URL: https://codereview.chromium.org/93593003
    
    TBR=koz@chromium.org
    
    Review URL: https://codereview.chromium.org/127843005
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243703 0039d316-1c4b-4281-b951-d872f2087c98
    c7c0c92c
launcher.cc 14.8 KB