• Akihiro Ota's avatar
    Revert "Support compressed .json grit files, compress chromevox msgs (Take 3)" · c7ee8316
    Akihiro Ota authored
    This reverts commit bdf15246.
    
    Reason for revert:
    
    When running ChromeVox on the ChromeOS Linux emulator, an error occurs when loading ChromeVox messages. This is indicated by the following error:
    
    Unable to load message file: /usr/local/google/home/<ldap>/chromium/src/out/cros/resources/chromeos/accessibility/chromevox/_locales
    
    Then, whenever ChromeVox attempts to look up a message defined in chromevox_strings.grd, the following error is displayed:
    
    Uncaught Error: Invalid ChromeVox message id: <message_id>
    
    Bug: 1030986
    
    Original change's description:
    > Support compressed .json grit files, compress chromevox msgs (Take 3)
    >
    > This provides support for type="chrome_messages_json_gzip" in
    > grit/build.py, which compresses the output files (which should have
    > .gz appended to the name, e.g. messages.json.gz).
    >
    > This makes it fairly simple to convert an extension (e.g. chromevox)
    > to use compressed l10n files.
    >
    > Original CL:
    > https://chromium-review.googlesource.com/c/chromium/src/+/1913610
    >
    > For changes reviewed in the original CL:
    > TBR=agrieve@chromium.org
    > TBR=dtseng@chromium.org
    > TBR=rdevlin.cronin@chromium.org
    >
    > Bug: 1023568
    > Change-Id: I7f83e5de8e339aea2e47b84f3ec701350246b38d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947386
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#720779}
    
    TBR=stevenjb@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org,agrieve@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1023568
    Change-Id: Id79a63a2977a1c273597195d4682661a7c5a379f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951977Reviewed-by: default avatarAkihiro Ota <akihiroota@chromium.org>
    Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#721820}
    c7ee8316
BUILD.gn 15.6 KB