GitLab

While having these enums since r396989 makes callsites more readable,
I find that most of the time for simple use cases in tests I don't care
much about the ResetPolicy (one time usage) and always want it to be
NOT_SIGNALED initially.

Surverying the codebase yields a slight majority of MANUAL over
AUTOMATIC (from experience I've written AUTOMATIC in some places where
it didn't matter either way as well). And NOT_SIGNALED is an obvious
winner for InitialState.

Also, IMO, MANUAL is the less-surprising default (i.e. can be used as a
flag).

As such I think having default arguments will vastly simplify
writeability for code using WaitableEvents (tests in particular). Few
sites will need to care and most that do will only need to specify the
ResetPolicy.

R=danakj@chromium.org

Bug: 612843
Change-Id: Ib0ef193b041e64ea9456748633bc49c64af60f19
Reviewed-on: https://chromium-review.googlesource.com/1053843Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557672}