-
Wenyu Fu authored
This reverts commit c41c5c46. Reason for revert: Changed to a different implementation, and fix the flaky test failed on M+ bots. Original change's description: > Revert "[HomepagePromo] Add finch param supressing_sign_in_promo" > > This reverts commit 25269f24. > > Reason for revert: test testSetUp_SuppressingSignInPromo fails constantly in android-arm64-proguard-rel (and fyi builder android-marshmallow-x86-fyi-rel) since > * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2020 > * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/767 > > Original change's description: > > [HomepagePromo] Add finch param supressing_sign_in_promo > > > > Adding the option for homepage promo to suppress the sign in promo when > > user is not signed in. > > > > Bug: 1068831 > > Change-Id: I854109c4623c47f98aab1faa34f94f2d55961474 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252379 > > Commit-Queue: Wenyu Fu <wenyufu@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#781109} > > TBR=twellington@chromium.org,wenyufu@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1068831 > Change-Id: I97f226e93962469cc8a705e922a3db72d7e84cd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265398 > Reviewed-by: Haiyang Pan <hypan@google.com> > Reviewed-by: Wenyu Fu <wenyufu@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#782189} TBR=twellington@chromium.org,hypan@google.com,wenyufu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068831 Change-Id: Id652d450f84f44f4d15b2409c61c3cf84fa7c48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269484 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#785953}
c9e213f4