• Ioana Pandele's avatar
    Fix export reset when completionWithItemsHandler is not called · cad67bd4
    Ioana Pandele authored
    Re-enable password export when the activity view disappears, instead of when completionWithItemsHandler is called. This has the potential to be a premature re-enabling, if the user decides to background the app launched from the activity view and come back to Chrome’s password settings. Re-triggering the export in this case might cause a conflict between multiple exported files.
    
    To mitigate this issue, each exported file is stored in its own uniquely identified folder in tmp/passwords/. If completionWithItemsHandler is called, the file and its folder are removed. For the cases in which the completion handler is not called, the rest of the files are deleted at startup.
    
    
    Bug: 820053
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I5683acfe8483876c0aeb81ce25ba83b24f109676
    Reviewed-on: https://chromium-review.googlesource.com/974181
    Commit-Queue: Ioana Pandele <ioanap@chromium.org>
    Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#546148}
    cad67bd4
main_controller.mm 102 KB