• Sean Topping's avatar
    Revert "[Chromecast] Refactor and Simplify CastWebView" · cafbb262
    Sean Topping authored
    This reverts commit 6d514087.
    
    Reason for revert: b/149569123
    
    Original change's description:
    > [Chromecast] Refactor and Simplify CastWebView
    > 
    > CastWebView forces too much indirection from the underlying page/window
    > functionality, so some forwarding methods have been removed in favor of
    > calling the members directly. This is presently not ideal, but will be a
    > great improvement once the CastWebContents and CastContentWindow are
    > surfaced as mojo interfaces via CastWebService and their lifetimes can
    > be tracked independently.
    > 
    > The CastWebService API has been simplified so that clients no longer
    > need to provide a SiteInstance when creating CastWebViews. The renderer
    > preloading logic, which was previously disjoint from CastWebView, has
    > now been incorporated.
    > 
    > Merge-With: eureka-internal/331288
    > 
    > Bug: internal 77879457
    > Test: CQ, manually verify on display assistant device.
    > Change-Id: I72fc57f0669783f61076626962d47b72d93463f6
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968257
    > Reviewed-by: Yuchen Liu <yucliu@chromium.org>
    > Commit-Queue: Sean Topping <seantopping@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#740143}
    
    TBR=sanfin@chromium.org,seantopping@chromium.org,yucliu@chromium.org,lijiawei@chromium.org,mdellaquila@google.com,zxliang@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: internal 77879457
    Change-Id: I9a6445b7a76e681e2f9c7e155c18058481e88684
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065850Reviewed-by: default avatarSean Topping <seantopping@chromium.org>
    Reviewed-by: default avatarYuchen Liu <yucliu@chromium.org>
    Commit-Queue: Sean Topping <seantopping@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#742893}
    cafbb262
cast_web_view_default.cc 10.3 KB