• Meilin Wang's avatar
    Reland "ambient: Show lockscreen contents on detecting user interaction." · cb7a6cbf
    Meilin Wang authored
    This reverts commit b3f1a19a.
    
    Reason for revert: The original CL broke the test because the expected
    behavior has been updated for that test case. The try bot didn't alert
    this failure as the failed test was flaky. Patchset 3 fixed this
    temporarily by deleting the obsolete test case. I will add more test
    cases to guard the updated behavior and deflake the original test in a
    follow-up CL.
    
    Original change's description:
    > Revert "ambient: Show lockscreen contents on detecting user interaction."
    >
    > This reverts commit 660c9cef.
    >
    > Reason for revert: AmbientContainerViewTest.MouseClickClosesWidgetAndStopsTimer failing deterministically on several linux-chromeos bots. Please see https://crbug.com/1068745 for more information.
    >
    > Original change's description:
    > > ambient: Show lockscreen contents on detecting user interaction.
    > >
    > > In ambient mode, when user interacting with the background image by
    > > mouse or gesture, lock screen contents (login pod and media control
    > > view) need be shown on top for users to either do re-authentication,
    > > or media control.
    > >
    > > This CL implements a prototype of this view transaction by:
    > > 1. Show the lock screen contents, and
    > > 2. Fade-out the current shown image.
    > >
    > > Bug: b/149246238
    > > Test: manually.
    > > Change-Id: Ie31c666cdfaddefc863ff8173dc185d73ef19178
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110689
    > > Commit-Queue: Meilin Wang <meilinw@chromium.org>
    > > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#757120}
    >
    > Change-Id: I395a7c02c6aa292f66ca5d9b4aefa9156e057773
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: b/149246238, 1068745
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139369
    > Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
    > Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#757223}
    
    Bug: b/149246238, 1068745
    Change-Id: I196c60cb21917dd84f9e7018950d5bf1b788b1ff
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141067
    Commit-Queue: Meilin Wang <meilinw@chromium.org>
    Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#760196}
    cb7a6cbf
ambient_container_view.cc 3.3 KB