• Caleb Raitto's avatar
    Disable leaking browser_tests on LSAN. · cb7f1cfe
    Caleb Raitto authored
    See crrev.com/c/1590404 and the linked bug for context -- the goal is to
    fix the broken memory-leak checking in Chromium's ASAN
    (AddressSanitizer) trybots, which are supposed to also run LSAN
    (LeakSanitizer).
    
    Currently-leaking tests must be fixed or disabled before leak checking
    can be enabled in the ASAN trybot.
    
    WARNING: This will result in a loss of ASAN coverage for the affected
    tests given that LSAN runs as part of the ASAN trybot.
    
    If that's not acceptable, we can wait until the leaks are fixed before
    fixing leak detection in trybots, but keep in mind that newly-introduced
    leaks Chromium-wide won't be caught until then.
    
    Bug: 961017
    Change-Id: Ie2d163715da8322c8727030a153ed9600462a7ce
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636866
    Commit-Queue: Caleb Raitto <caraitto@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
    Reviewed-by: default avatarFinnur Thorarinsson <finnur@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#666306}
    cb7f1cfe
app_browsertest.cc 55.8 KB