• Alex Cooper's avatar
    [XR] Ensure that selectend and selectstart events are always paired · cb872f62
    Alex Cooper authored
    Per the spec, a selectend event should always be sent if a selectstart
    event has been fired, evenif the gesture is cancelled.  Currently if an
    input source was removed but it had sent a selectstart event a selectend
    event would never be sent.  This fixes that for both the cases where an
    input source is lost, and if the session ends while a controller is
    pressed.
    
    Per the HTML interaction spec, since these removals cannot be
    guaranteed to have fired as a result of user interaction, the frame
    is not notified of UserActivation in this case (and as such the
    OnSelectEnd method is not re-used).
    
    Bug: 968291
    Change-Id: Ibea99e59ee7a528b7a34db610bfca76c27d495b9
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636851Reviewed-by: default avatarBill Orr <billorr@chromium.org>
    Reviewed-by: default avatarBrandon Jones <bajones@chromium.org>
    Commit-Queue: Alexander Cooper <alcooper@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#664805}
    cb872f62
xr_session.h 9.29 KB