• Glen Robertson's avatar
    Remove ConfigureNetworkContextParams from profile. · cbb40ac3
    Glen Robertson authored
    This was a method call simply passed through to profile so that
    chrome_content_browser_client.cc could have different behaviour for
    testing profiles. It introduced a dependency "up" the build hierarchy
    (in the wrong direction) when profile should be a dependency leaf
    within //chrome/browser. That made #include cycles which prevent profile
    from being extracted into a separate target.
    
    Unfortunately, need to early-construct
    ProfileNetworkContextServiceFactory in
    ChromeBrowserMainExtraPartsProfiles so that ServiceIsNULLWhileTesting
    works as expected.
    
    Bug: 1149277,1150733
    Change-Id: I608ec127813086db3aa5550e2fe9af5afb7b7e05
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539813
    Commit-Queue: Glen Robertson <glenrob@chromium.org>
    Reviewed-by: default avatarDavid Roger <droger@chromium.org>
    Reviewed-by: default avatarAlan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#830083}
    cbb40ac3
profile.h 20.3 KB