• Hirokazu Honda's avatar
    Revert "Add support for variadic arguments in generated stubs" · cc6ae6a3
    Hirokazu Honda authored
    This reverts commit d27bb543.
    
    Reason for revert: This CL causes HW encoding functionality loss on some Chrome OS devices, minnie and kevin.
    
    Original change's description:
    > Add support for variadic arguments in generated stubs
    >
    > Previously we were using va_list for variadic arguments. The downside
    > for this was that only the first value from the variadic argument was
    > passed to the original function.
    >
    > To make it work properly we have to use the __VA_ARGS__ variadic macro
    > that was introduces in C99 and is available in all major C/C++
    > compilers.
    >
    > Change-Id: I50652f7348a16214811aaab8af116d78cdb70444
    > Reviewed-on: https://chromium-review.googlesource.com/c/1323089
    > Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com>
    > Cr-Commit-Position: refs/heads/master@{#606588}
    
    TBR=phoglund@chromium.org,dpranke@chromium.org,braveyao@chromium.org,brucedawson@chromium.org,tomas.popela@gmail.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 904586
    Change-Id: I04157ea305decc170d5efd4ba228c92bd4020ef6
    Reviewed-on: https://chromium-review.googlesource.com/c/1333013
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: default avatarHirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607545}
    cc6ae6a3
generate_stubs_unittest.py 12.5 KB