• Maksim Ivanov's avatar
    Revert "Reland: "Add --merge-base-ref option to lastchange.py"" · cd0e1d01
    Maksim Ivanov authored
    This reverts commit 5f2e9a96.
    
    Reason for revert: gclient sync fails with the following error:
    
      ________ running '/usr/bin/python src/build/util/lastchange.py -o src/build/util/LASTCHANGE' in '/mnt/sdd/chrome'
      ERROR:root:Failed to get version info: %s
    
    Original change's description:
    > Reland: "Add --merge-base-ref option to lastchange.py"
    > 
    > Reland commit f4f6c5ff
    > Revert was 172ccc05
    > 
    > The previous attempt at a reland changed FetchGitRevision
    > which caused breakage when
    > chrome/test/chromedriver/embed_version_in_cpp.py attempted to call this
    > function. https://crrev.com/c/1459921 was recently merged which
    > completely removed embed_version_in_cpp.py which should allow
    > this change to re-land without modification from the previous
    > attempt at a reland.
    > 
    > Change-Id: I0dbd7436938ae27167a9381415277d95d0d8312f
    > Bug: 917159
    > Reviewed-on: https://chromium-review.googlesource.com/c/1460454
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    > Commit-Queue: Eli Ribble <eliribble@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#633730}
    
    TBR=dpranke@chromium.org,tandrii@chromium.org,eliribble@chromium.org
    
    Change-Id: Ia644ba3b8fe50b38fec26959a298f0d269fa54c9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 917159
    Reviewed-on: https://chromium-review.googlesource.com/c/1479950Reviewed-by: default avatarMaksim Ivanov <emaxx@chromium.org>
    Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#633886}
    cd0e1d01
lastchange.py 7.29 KB