• Rushan Suleymanov's avatar
    [Sync] Fix reupload of bookmarks without favicons on iOS · cdca14f4
    Rushan Suleymanov authored
    Prior to this patch any favicon change on iOS devices would cause
    bookmark reupload on each remote update (which contained favicon).
    Furthermore, any remote update with favicon could trigger favicon
    changed event.
    
    This CL checks if there is actual favicon in specifics before updating
    current entity on favicon changed event coming from the BookmarkModel.
    It is prevents entity from being reuploaded without favicon on
    incremental remote update.
    
    Bug: 1075709
    Change-Id: Ie15dcc62160a0851b2ce8e40ce0ef20eff43f995
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283214
    Commit-Queue: Rushan Suleymanov <rushans@google.com>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#786281}
    cdca14f4
bookmark_model_observer_impl_unittest.cc 42.6 KB