• Henry Jian's avatar
    Reland "[Android WebAPK] Create resources for web shortcuts." · ce816737
    Henry Jian authored
    This is a reland of commit 274ea563
    Previously, the original commit was reverted to land another CL and push
    the shell apk immediately. There was nothing wrong with the original CL.
    Since the other CL was landed and pushed, we can now reland this CL.
    
    Original change's description:
    > [Android WebAPK] Create resources for web shortcuts.
    >
    > Resources used need to be pre-declared in the shell.
    >
    > Since we don't know how many shortcuts are needed for a web app until
    > the creation request, we create 4 copies of the needed resources to
    > declare a shortcut, since that is the maximum number of shortcuts
    > allowed on Android.
    >
    > The following resources are needed (per shortcut):
    > - name
    > - short_name
    > - icon (placeholder taken from
    >     https://material.io/resources/icons/?icon=filter_1&style=baseline)
    
    > The shortcuts.xml is also partially generated to use the resources, so
    > that building the shell apk doesn't fail. They are all disabled by
    > default, and will need to be re-enabled on the server-side.
    
    > Bug: 1010471
    > Change-Id: I5371b145afd943029de8eb679b0cf3044545cbe3
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875755
    > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
    > Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
    > Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#709189}
    
    Bug: 1010471
    Change-Id: I72d7bb00e7bd80063e9eb5f87f61467ddc7a6889
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895864
    Commit-Queue: Henry Jian <hzjian@google.com>
    Reviewed-by: default avatarPeter Kotwicz <pkotwicz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#712192}
    ce816737
android_webapk_strings.grd 11.5 KB