-
Xiaocheng Hu authored
This patch reimplements TextIteratorTextNodeHandler on top of the NG offset mapping APIs to make TextIterator work with Layout NG. Most critical changes are in TextIteratorTextNodeHandler.cpp, which gives a new and clean implementation of the class. Other changes are rebaseline of layout tests and changes to test expectations. New failure due to LayoutText writeback: - editing/text-iterator/findString-restarts-at-last-position.html - editing/pasteboard/19644-1.html - editing/pasteboard/19644-2.html - virtual/layout_ng/fast/block/float/overhanging-float-crashes-when-sibling-becomes-formatting-context.html - minimal repro: https://jsfiddle.net/767q3cbc/. There should be a trailing space in |container.innerText|, which is missing when LayoutNG is enabled New failures due to lack of support for rect-related APIs: - accessibility/selection-affinity.html - fast/multicol/float-truncation.html - fast/multicol/vertical-lr/float-truncation.html Some new failures are due to irrelevant bugs in layout test framework. Other tests are rebaselined. Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8670c1d879437a36788c6ff50d83c7609cf08e79 Reviewed-on: https://chromium-review.googlesource.com/580371Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#493273}
95a91226