• manukh's avatar
    [omnibox] [rich-autocomplete] Un-overload OEM::OnPopupDataChanged param. · cec9fc47
    manukh authored
    OmniboxEditModel::OnPopupDataChanged params include:
    - |text| representing either the temporary or suffix autocompletion
    texts.
    - |is_temporary_text| to distinguish the 2 cases.
    - |prefix_autocompletion|
    
    The overloaded use of |text| is confusing, especially now that
    autocompletion consists of more than 1 string field
    (prefix_autocompletion and we expect to add split_autocompletion in the
    future).
    
    This CL replaces |text| with |temporary_text| and
    |inline_autocompletion|.
    
    Bug: 1062446
    Change-Id: I5aa4535db1f9d4a85dced041f920d2f90afe0bda
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427025
    Commit-Queue: manuk hovanesian <manukh@chromium.org>
    Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#812106}
    cec9fc47
omnibox_controller.cc 3.76 KB