• Ian Barkley-Yeung's avatar
    Add VLOGs to diagnose missing broker processes. · ceddc919
    Ian Barkley-Yeung authored
    We are still seeing lots of flakes on tast test
    ChromeCrash[Not]LoggedIn.broker because it cannot find a broker
    process to kill. My current hypothesis is that sometimes the broker
    process's call to setproctitle() is failing. setproctitle() will
    silently fail if something goes wrong, which is normally fine (it's just
    to make `ps` output better) but which messes up the integration tests.
    
    Add some VLOGs to confirm or deny. In particular, by logging the PID of
    the broker process, I can compare to ps.txt and see if that process
    exists with a different title.
    
    Change
    https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1888317
    will activate the VLOGs during the tests.
    
    BUG=chromium:984807
    TEST=Ran tast -verbose run --extrauseflags chrome_internal my_crbook
    ui.ChromeCrashLoggedIn.broker with change 1888317. Saw expected output
    in logs.
    
    Change-Id: I5ab77ff36194cd3fe7e2b7d69e7426738baae33b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888870
    Commit-Queue: Robert Sesek <rsesek@chromium.org>
    Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
    Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#711715}
    ceddc919
broker_process.cc 12.8 KB