-
avi authored
Revert of [chrome_elf] Big cleanup and removing dependencies that recently crept in. Part 1. (patchset #9 id:300001 of https://codereview.chromium.org/2183263003/ ) Reason for revert: Win7 Tests (dbg)(1) started failing. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/51720 Excerpt from step 103, chrome_elf_unittests on Windows-7-SP1 chrome_elf_unittests on Windows-7-SP1 : [ RUN ] HookTest.IATHook Assertion failed: false, file c:\b\c\b\win\src\chrome_elf\hook_util\hook_util.cc, line 302 [43/49] HookTest.IATHook (TIMED OUT) Original issue's description: > [chrome_elf] Big cleanup and removing dependencies that recently crept in. PART 1. > > - Moving all crash related APIs into one place (and out of chrome_elf_main). > - Started to clean up external dependencies - starting with hook_utils. > - Removed dependency on base/win/iat_patch_function. > > BUG=631771 > > Committed: https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58 > Cr-Commit-Position: refs/heads/master@{#411982} TBR=robertshield@chromium.org,pennymac@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631771 Review-Url: https://codereview.chromium.org/2242323002 Cr-Commit-Position: refs/heads/master@{#412026}
4e989fa8
