• Jesse McKenna's avatar
    Reland "desktop-pwas: Set display name for Open With menu" · cf430c01
    Jesse McKenna authored
    This relands crrev.com/c/1810242, reverted by crrev.com/c/1815802.
    
    Unit test ShellUtilRegistryTest.AddFileAssociations was failing on
    Windows 7 bots when checking for registry key
    HKCU\Software\Classes\<progID>\Application, because this key is only
    created by ShellUtil::AddFileAssociations() on Windows 8 and later. I
    changed this CHECK() to only take place when on Windows 8 or later.
    
    Original change description:
    
    When an application is registered as a handler for a file type, the name
    that is displayed in the "Open With..." menu for that file type is
    controlled by registry value
    HKCR/<application ProgID>/Application::ApplicationName.
    
    This change extends ShellUtil::AddFileAssociations(), which will soon be
    used to register Progressive Web Apps (PWAs) as file handlers on
    Windows, to set ApplicationName. This enables PWAs registered as file
    handlers to appear in the "Open With..." menu with a readable display
    name such as "My PWA".
    
    Bug: 960245
    Change-Id: I0790faa2b3eedec82ace2c324ff582515af048aa
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818429
    Commit-Queue: Jesse McKenna <jessemckenna@google.com>
    Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#699518}
    cf430c01
shell_util.cc 104 KB