• Nektarios Paisios's avatar
    Workaround for bug in NGInlineOffsetMappingBuilder whereby it does not assign... · cf48348c
    Nektarios Paisios authored
    Workaround for bug in NGInlineOffsetMappingBuilder whereby it does not assign mapping units to empty LayoutText objects
    
    When using legacy layout, NGInlineOffsetMappingBuilder computes the text offset mappings fon demand
    and caches them in the layout object's rare data.
    However, due to a bug in that computation, empty LayoutText objects
    are not given a corresponding OffsetMappingUnit in the list of offset mappings
    causing a crash.
    
    This workaround ignores such objects for now, returning the
    best possible value, until NGInlineOffsetMappingBuilder is fixed to handle this situation.
    
    AX-Relnotes: n/a.
    
    R=dmazzoni@chromium.org, aleventhal@chromium.org
    
    Bug: 1149171
    Change-Id: I7a59f924cf94d0b40ca47cbe2be402b3fe68addd
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578098
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#834612}
    cf48348c
ax_position.cc 44.3 KB