GitLab

M84 is crashing because OmahaService::Stop() is somehow called before
the OmahaService singleton is created. This causes Stop() to try and
create a new service object during shutdown, which crashes.

This CL sidesteps the crash by making it safe to create a new
OmahaService object, even at shutdown. The unsafe portions of the
constructor were already in StartInternal(), which now needs to be
explicitly invoked by OmahaService::Start().

BUG=1105799

Change-Id: Idd9531ab0ac79e4520deaa2145e9d3efc20bb01d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339719Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795980}