-
msw@chromium.org authored
The original r272259 was reverted for test failures on Windows XP. http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31296 FocusTraversal[OnInterstitial] times out on Windows XP with no output: [ RUN ] BrowserFocusTest.FocusTraversal [3796:3464:0522/144031:ERROR:gpu_info_collector_win.cc(103)] Can't retrieve a valid WinSAT assessment. [3796:380:0522/144031:WARNING:embedded_test_server.cc(230)] Request not handled. Returning 404: /favicon.ico [397/398] BrowserFocusTest.FocusTraversal (TIMED OUT) As InterstitialFocus passes, TestFocusTraversal is probably at fault. I disabled that helper on XP with a comment for Issue 376635. The original description is otherwise accurate as follows: ======================================== Fix FocusTraversal[OnInterstitial] except *OnInterstitial on Mac :( Fix InterstitialFocus and FindFocusTest. Add a TestFocusTraversal helper function consolidated from tests. Simplify TestInterstitialPage and add a WaitForInterstitial helper. Move test server init to a common SetUpOnMainThread. Remove unnecessary helpers and includes. TODO(followup): Fix more tests! TODO(followup): s/DisableFindBarAnimationsDuringTesting/ScopedAnimationDurationScaleMode/? BUG=60973, 62544, 67301, 81451, 109770, 163931, 376635 TEST=Automated tests work and stay enabled... TBR=sky@chromium.org Review URL: https://codereview.chromium.org/292363006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272588 0039d316-1c4b-4281-b951-d872f2087c98
cfd33794
