• glider's avatar
    Another attempt to fix debug info stripping for ASan on OSX · d051b21c
    glider authored
    Unce upon a time the ASan runtime library used to be statically linked into
    the executables on OSX.
    Because that library provided a number of API functions needed by the shared
    libraries, we had custom ASan-specific .saves files that told the `strip`
    utility to preserve those functions when stripping the executables.
    
    Then ASan switched to using dynamic runtime library, which instantly broke the
    stripping step, because the executables weren't necessarily referencing all the
    ASan API functions (issue 242503).
    As a result, stripping has been disabled, and we haven't had .dSYM debug info
    for ASan builds for more than a year now (issue 148383).
    
    Because the ASan API functions are now undefined in the executables, it's
    actually senseless to use the .saves files to preserve those functions in each
    executable. However __asan_default_options still must be preserved to be accessible
    from the ASan runtime.
    
    This CL removes all ASan symbols except for __asan_default_options from the .saves files
    and makes Chromium.app and Chromium Helper.app correctly use app_asan.saves.
    It also turns mac_strip_release on for ASan builds.
    
    BUG=148383,242503,170739,166857
    R=mark@chromium.org
    TBR=cpu@chromium.org
    
    Review URL: https://codereview.chromium.org/560323004
    
    Cr-Commit-Position: refs/heads/master@{#296413}
    d051b21c
app_asan.saves 538 Bytes