• ccameron's avatar
    Revert of Update geolocation permission tests for the permission bubble... · d063c314
    ccameron authored
    Revert of Update geolocation permission tests for the permission bubble (patchset #18 id:340001 of https://codereview.chromium.org/787033004/)
    
    Reason for revert:
    Getting intermittent failures in GeolocationBrowserTest after this patch
    
    Failing build:
    https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/35949/steps/browser_tests
    
    Output:
    GeolocationBrowserTestWithParams/GeolocationBrowserTest.NoLeakFromOffTheRecord/1 (run #1):
    [ RUN      ] GeolocationBrowserTestWithParams/GeolocationBrowserTest.NoLeakFromOffTheRecord/1
    [3952:1032:0204/052930:WARNING:data_reduction_proxy_settings.cc(345)] SPDY proxy OFF at startup
    [3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(156)] LegacyRenderWidgetHostHWND::OnGetObject message=61 w_param=0 l_param=-12 obj_id=4294967284 host_=00000000
    [3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(129)] LegacyRenderWidgetHostHWND::Init hwnd=04CF00A6
    [3952:1032:0204/052930:WARNING:geolocation_browsertest.cc(383)] before navigate
    [3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(156)] LegacyRenderWidgetHostHWND::OnGetObject message=61 w_param=0 l_param=-12 obj_id=4294967284 host_=00000000
    [3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(129)] LegacyRenderWidgetHostHWND::Init hwnd=08B500B0
    [3952:1032:0204/052931:WARNING:geolocation_browsertest.cc(398)] after navigate
    [3952:1032:0204/052931:WARNING:geolocation_browsertest.cc(234)] will add geolocation watch for bubble
    [3952:1032:0204/052931:WARNING:geolocation_browsertest.cc(201)] javascript_response 1
    [3952:3868:0204/052931:WARNING:embedded_test_server.cc(248)] Request not handled. Returning 404: /favicon.ico
    
    Output not very helpful here, but perhaps it makes sense to a non-sheriff.
    
    Original issue's description:
    > Update geolocation permission tests for the permission bubble
    >
    > This makes the geolocation permission tests run for both infobars and
    > permission bubbles. The tests now run as parameterized tests.
    >
    > Supercedes parts of:
    > https://codereview.chromium.org/411503005/
    > https://codereview.chromium.org/341833004/
    >
    > BUG=438758
    >
    > Committed: https://crrev.com/f57c61952870c6027dbf220eff8b2d703bfed3c8
    > Cr-Commit-Position: refs/heads/master@{#314541}
    
    TBR=mvanouwerkerk@chromium.org,timvolodine@google.com,markusheintz@chromium.org,felt@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=438758
    
    Review URL: https://codereview.chromium.org/902643003
    
    Cr-Commit-Position: refs/heads/master@{#314602}
    d063c314
geolocation_browsertest.cc 31.6 KB