• Philip Rogers's avatar
    Revert "Skip commits for painted scrollbar thumb movement" · d07cb69a
    Philip Rogers authored
    This reverts commit 3088046f.
    
    Reason for revert: Suspected as causing a ProxyCommit regression.
    
    Original change's description:
    > Skip commits for painted scrollbar thumb movement
    > 
    > Painted scrollbars are used for overlay scrollbars on MacOS. Thumb
    > movement would cause a commit on every scroll change because the update
    > rect (set via Layer::SetNeedsDisplay) would change. This patch ignores
    > the update rect in PaintedScrollbarLayer::Update and uses part
    > invalidation for causing commits. With this change, scroll offset
    > changes do not cause commits.
    > 
    > Bug: 1048384f
    > Change-Id: I79bac7fbd9756cb71af7c3b83be3df824dd7a5cf
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078847
    > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    > Commit-Queue: Philip Rogers <pdr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#745544}
    
    TBR=wangxianzhu@chromium.org,pdr@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1048384f, 1059436
    Change-Id: I7e6e36fca7afecae35d969ca655965984a90e891
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092185Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#747976}
    d07cb69a
scrollbar_layer_unittest.cc 58 KB