• Jan Wilken Dörrie's avatar
    Reland "Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"" · d0a3dc6f
    Jan Wilken Dörrie authored
    This reverts commit dfa8728a.
    
    Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by a CL this one depended on.
    
    Original change's description:
    > Revert "Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors""
    > 
    > This reverts commit ffac89b5.
    > 
    > Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg) crbug.com/870208
    > 
    > Original change's description:
    > > Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
    > > 
    > > This reverts commit d01b7c9e.
    > > 
    > > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
    > > 
    > > Original change's description:
    > > > Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"
    > > > 
    > > > This reverts commit f61df6f9.
    > > > 
    > > > Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change.
    > > > 
    > > > Sample builds:
    > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242
    > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240
    > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236
    > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235
    > > > 
    > > > failures:
    > > > BluetoothTestWinrtOnly.GattServices_ObserversCalls/0
    > > > BluetoothTestWinrt.GetPrimaryServices/1
    > > > BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1
    > > > BluetoothTestWinrt.GetPrimaryServicesByUUID/1
    > > > BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0
    > > > BluetoothTestWinrt.GetGattServices_and_GetGattService/1
    > > > BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1
    > > > BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0
    > > > 
    > > > Original change's description:
    > > > > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors
    > > > > 
    > > > > This change implements reading and writing of Remote Gatt Descriptors
    > > > > for WinRT. Furthermore, it enables corresponding tests.
    > > > > 
    > > > > Bug: 821766
    > > > > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe
    > > > > Reviewed-on: https://chromium-review.googlesource.com/1156703
    > > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    > > > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
    > > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#579838}
    > > > 
    > > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
    > > > 
    > > > Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7
    > > > No-Presubmit: true
    > > > No-Tree-Checks: true
    > > > No-Try: true
    > > > Bug: 821766
    > > > Reviewed-on: https://chromium-review.googlesource.com/1159961
    > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#580062}
    > > 
    > > TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
    > > 
    > > Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Bug: 821766
    > > Reviewed-on: https://chromium-review.googlesource.com/1160902
    > > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#580201}
    > 
    > TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
    > 
    > Change-Id: I0b4eac30dd4f35b8fb275bed74d69f7b7b1b0f38
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 821766,870208
    > Reviewed-on: https://chromium-review.googlesource.com/1161681
    > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#580440}
    
    TBR=kinuko@chromium.org,reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 821766, 870208
    Change-Id: Icaf844c0c0aa72ab38db3e834df3100088339f1b
    Reviewed-on: https://chromium-review.googlesource.com/1163384Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#580837}
    d0a3dc6f
fake_gatt_descriptor_winrt.h 3.61 KB