• Trent Apted's avatar
    Support typography styles in views::StyledLabel. · d0c7052e
    Trent Apted authored
    Adds initial support to views::Link as well, by allowing it to pass
    TextContext to its parent views::Label constructor.
    
    The entire StyledLabel has a single TextContext. A default TextStyle
    can be optionally overridden on a RangeStyleInfo.
    
    Audited the StyledLabel consumers: One consumer (EchoDialogView)
    uses underlined text outside of a Link. The dialog is under review
    (http://crbug.com/768663), so don't add a style for it.
    
    The PageInfoBubble was the only consumer that wanted an underline on
    its links. Remove underlines from all links in the page info bubble for
    consistency with the rest of Chrome's UI.
    
    All the (slow) FontList::Derive(..) calls disappear from StyledLabel.
    Most fonts just come from the ResourceBundle cache now, unless they
    need a custom_font (which is currently just EchoDialogView).
    
    Bug: 691891
    Change-Id: I6cca4480d366d2578ac01da4d604a414415ffbc4
    Reviewed-on: https://chromium-review.googlesource.com/649930
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarBret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#505246}
    d0c7052e
styled_label_unittest.cc 24.6 KB