• Avi Drissman's avatar
    Revert "MacViews: Remove JavaScriptAppModalDialogCocoa" · d1f914d0
    Avi Drissman authored
    This reverts commit 74d2ba14.
    
    Reason for revert:
    
    This breaks the dialog.
    
    The beforeunload dialog *must* block all of Chrome. MacViews does not have the modality code do to so yet. If you implement that modality you may reland this.
    
    Original change's description:
    > MacViews: Remove JavaScriptAppModalDialogCocoa
    > 
    > Move from using Cocoa to using Views. The Cocoa version was was causing
    > problems with app exit dialogs showing up in the wrong process in
    > RemoteMacViews. This issue was solved by the views version.
    > 
    > Bug: 898604
    > Change-Id: I30bd1e543fa98a1503d80b4ad3947f676eb5e0c6
    > Reviewed-on: https://chromium-review.googlesource.com/c/1298300
    > Commit-Queue: ccameron <ccameron@chromium.org>
    > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#605898}
    
    TBR=ellyjones@chromium.org,ccameron@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 898604
    Change-Id: I5ec60bc8490083175092da9b4f2d0a2167aac18a
    Reviewed-on: https://chromium-review.googlesource.com/c/1331831Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607418}
    d1f914d0
native_widget_mac.mm 29.7 KB