• Andrew Xu's avatar
    [scrollable shelf] Utilize layer clip for shelf container view · d2c567fe
    Andrew Xu authored
    Now in ScrollableShelfView, |shelf_container_view_|'s bounds change
    depending on the layout strategy. In this CL, |shelf_container_view_|'s
    bounds are never changed. Instead, its layer is clipped and the clip
    rectangle is calculated with the layout strategy. It lays the basis to
    solve the issue 1009368. This CL should not introduce any visual change
    
    In detail, this CL does the following things:
    (1) For |shelf_container_view_|, use layer clip instead of setting
    bounds.
    (2) Handles the tooltip correctly. In the current code, we use
    |shelf_container_view_|'s bounds to decide whether to show/hide the
    app icon's tooltip.
    (3) Handles located events correctly. |shelf_container_view_| should
    only handle those events within the area after clip.
    
    Bug: 1009368
    Change-Id: Iead6a53da1d06d831d13a7847722f51ea5c9b9cb
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849096
    Commit-Queue: Andrew Xu <andrewxu@chromium.org>
    Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#705230}
    d2c567fe
shelf_container_view.h 1.33 KB