• Jordy Greenblatt's avatar
    [CrOS MultiDevice] Block false Settings error from ambiguous listener. · d2d014a7
    Jordy Greenblatt authored
    The settings-multidevice-setup-page listens for the event 'close'
    as a proxy for the password prompt being confirmed. However, the
    event type 'close' is ubiquitous to cr-dialog so it also fires when
    the forget device dialog is closed on the subpage, which causes the
    assertion "assert(this.featureToBeEnabledOnceAuthenticated_ !== null)"
    in SettingsMultidevicePageElement.onPasswordPromptDialogClose() to
    fail.
    
    This CL only calls onPasswordPromptDialogClose_ if the close event came
    from the MultiDevice page's password prompt and stops the event's
    propagation.
    
    Bug: 887160
    Change-Id: I5740061c8f9e08ee5ba9e8d99862bcec6b0a6677
    Reviewed-on: https://chromium-review.googlesource.com/1235321
    Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
    Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#592908}
    d2d014a7
multidevice_page.html 4.78 KB