GitLab

This CL updates the bytecode modifications we perform on
Fragment.getActivity() to have it call ContextUtils.activityFromContext(
getContext()), and modifies compile_java.py to detect compilation errors
related to this change and print a message pointing you to documentation
about the bytecode modifications.

A compilation error will now print:
../...../PasswordEntryEditor.java:144: error: cannot find symbol
                getActivity().getSupportFragmentManager(),
                             ^
  symbol:   method getSupportFragmentManager()
  location: class Activity
            Expecting a FragmentActivity? See docs/.......md

Bug: 1123216
Change-Id: I04016e30fba46c7d5c592e9ab2c5e5fa4c4cfde1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508352
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828643}