• Ankit Kumar's avatar
    Reland "Add contents of popup note associated with a highlight in PDF accessibility tree" · d543bbc7
    Ankit Kumar authored
    This is a reland of 9c48a1c1
    
    Original CL: http://crrev.com/c/2208832
    Revert CL: http://crrev.com/c/2247941
    
    Reason for revert:
    Causing PDFExtensionAccessiblity tests to fail on Mac Debug.
    
    The method GetStaticTextNodeFromNode() had an assumption that highlight
    node would only have one children. The original CL changed that as the
    popup note is added as a child of the highlight node.
    
    Original change's description:
    > Add contents of popup note associated with a highlight in PDF accessibility tree
    >
    > This CL adds the note text data associated with a highlight to the
    > accessibility tree. The CL makes the content of the note text accessible
    > to users via screen readers.
    >
    > Tests have been modified to validate the addition of note text data to
    > the accessibility tree.
    >
    > Bug: 1008775
    > Change-Id: I086d039b9296d0b8ac1b13926835375a7943f8c9
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208832
    > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
    > Reviewed-by: Lei Zhang <thestig@chromium.org>
    > Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#779008}
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_chromium_dbg_ng
    
    Bug: 1008775
    Change-Id: If9eb9ae1a0f975b99e00e01ca68e6d301989cd93
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249263Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#779572}
    d543bbc7
highlights-expected-blink.txt 1.08 KB