GitLab

Removing an unnecessary call to IsDefaultSiteInstance() in
RenderFrameHostManager. The condition the call was in expects
RequiresDedicatedProcess() to return true on the SiteInstance which
won't happen on a default SiteInstance.

- Removed IsDefaultSiteInstance() call from RFHM.
- Added a test that explicitly verifies that a default SiteInstance
  returns fals for RequiresDedicatedProcess() to help prove the
  call was not needed and ensure that we don't accidentally change
  this behavior.
- Converted DCHECK in set_process_reuse_policy() to a check to make
  sure we don't accidentally allow reuse to be set on production builds.

Bug: 1085275
Change-Id: I628df05fe1b2eb27031f8bec087913867717e9a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538251
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827481}