• cfredric's avatar
    Add braces to if statement in registration.cc · d60db6a1
    cfredric authored
    This makes no behavior change, since the if statement should only be
    inserted if the `RegisterPnaclComponent` call has also been inserted.
    However, it makes it clearer that there is no bug related to the missing
    bracket and an unintentionally un-inserted statement. I.e., a bug of the
    form:
    
    if (condition)
    # if SOME_FLAG
      conditional_stmt();
    # endif
    
    unconditional_stmt();
    
    Note that in the above snippet, if SOME_FLAG is false, then
    `unconditional_stmt` will unintentionally become conditional.
    
    Again, the current code does not exhibit this bug, but at a quick
    glance, that is not obvious.
    
    Change-Id: Ibb41d390ae5be698421266ad494ea03dcb95532f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617462Reviewed-by: default avatarJoshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#841545}
    d60db6a1
registration.cc 8.28 KB