• sczs's avatar
    [ios] Fixes InfobarCoordinator <-> Consumer memory leak. · d65b8de1
    sczs authored
    There was a retain cycle per bug 1004690.
    The ContainerCoordinator had a strong pointer to the Mediator, which in
    turn had a strong pointer to infobar_container_ios, which had a strong
    pointer to its consumer (ContainerCoordinator).
    
    This would only happen on non Messages, since on the legacy implementation
    the consumer is the ContainerViewController. Still I think both consumers
    should be weakly retained since the mediator(infobar_container_ios)
    don't really own these objects.
    
    Bug: 1004690
    Change-Id: Ic5d30b444177e216ffe2f8cdce9b0cf7d012383c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809744Reviewed-by: default avatarChris Lu <thegreenfrog@chromium.org>
    Commit-Queue: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#697490}
    d65b8de1
infobar_container_ios.h 1.84 KB