• Elly Fong-Jones's avatar
    views: remove DialogDelegate::ShouldUseCustomFrame · d679e73f
    Elly Fong-Jones authored
    This is now a property of an instance rather than a delegate method.
    
    This change introduces one minor behavior change: on Windows,
    HungRendererDialogView used to use a custom frame when Aero Glass was
    enabled; it will now use a custom frame when Aero Glass is enabled *or*
    the dialog is parented. I think the old behavior was a bug - it is not
    supported to use a custom frame with no parent window.
    
    Some reworking of the DialogTest suite was required, because this suite
    used to override ShouldUseCustomFrame to return true despite not having
    a parent widget for the test dialogs. This change introduces a parent
    widget so that these tests continue to get the custom frame they desire.
    
    Bug: 1011446
    Change-Id: Ib3a8521368e1d7d779c2346fc74c97633fd13f16
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846317Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
    Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#704614}
    d679e73f
dialog_delegate.h 8.46 KB