• Sunny Sachanandani's avatar
    Revert "Reland "media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation"" · d6b09b47
    Sunny Sachanandani authored
    This reverts commit 1364e616.
    
    Reason for revert: Increased crash rate - see crbug.com/1125954
    
    Original change's description:
    > Reland "media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation"
    > 
    > This is a reland of b71115a3
    > 
    > Relanding after triaging Gold failures on gpu.fyi bots in previous
    > attempt.
    > 
    > Original change's description:
    > > media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation
    > >
    > > Avoid a CPU side copy to account for mismatched strides between the
    > > decoded video frame and GPU texture created for uploading the frame.
    > > GL_UNPACK_ROW_LENGTH allows specifying the stride for glTexSubImage2D,
    > > and is part of the GL_EXT_unpack_subimage extension implemented by the
    > > command buffer on the client side.
    > >
    > > Also includes a pixel test with a VP8 video with a GL incompatible
    > > stride that doesn't match the video's coded size (992 vs 962).
    > >
    > > Bug: 1077211
    > > Change-Id: I62753234bde3b92e64089c92a59e65ae2bc1c84c
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386671
    > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    > > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#803696}
    > 
    > TBR=dalecurtis@chromium.org,zmo@chromium.org
    > 
    > Bug: 1077211, 1124215
    > Change-Id: I43a97e72cdd0ba633d4b374a2319fbc7dc7252f7
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390958
    > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#803960}
    
    TBR=dalecurtis@chromium.org,zmo@chromium.org,sunnyps@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1077211, 1125954
    Change-Id: I9c77f5e7694385ccdbbadcddf738135a18ca6412
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402124Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#805548}
    d6b09b47
pixel_test_pages.py 39.3 KB