• Alex Cooper's avatar
    Fix AccessViolation in WMR UpdateVisibilityState · d73b4e2d
    Alex Cooper authored
    While the runtime is stopping if the current sensor presence state is
    anything other than "NotPresent", a visibility state change event comes
    in.  This event gets unsubscribed in StopRuntime, but it's possible that
    the change comes in before the render loop knows that it needs to tear
    down the runtime, so simply unsubscribing earlier is insufficient to fix
    this. The fix is to just simply check whether or not holographic_space_
    is valid before running the rest of the logic.
    
    Fixed: 1018822
    Change-Id: I05298c6f20419cbad30cda3107924d0e207aaa2e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884288
    Commit-Queue: Alexander Cooper <alcooper@chromium.org>
    Commit-Queue: Jacob DeWitt <jacde@chromium.org>
    Auto-Submit: Alexander Cooper <alcooper@chromium.org>
    Reviewed-by: default avatarJacob DeWitt <jacde@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#710069}
    d73b4e2d
mixed_reality_renderloop.cc 31.4 KB