GitLab

gyp changes are made to filter out toolkit-views browser_tests that
aren't yet compiled in to a toolkit-views Chrome binary on Mac.

One, WebDialogBrowserTest.SizeWindow, was a disabled test (disabled for
4 years :o). It was preventing browser_tests compiling on MacViews
because it was passing a gfx::NativeWindow to CreateWindowWithParent,
which takes a view.

The parent isn't important for the test - it's just adding widget
context. This CL changes the parent to be web_contents->GetNativeView()
instead so the test compiles.

To ensure nothing breaks, the test needs to be enabled. According to the
comment, the reasons for it being disabled on Windows still seem
relevant. However, on Linux the test was just timing out due to a quirk
of the test. So the quirk is fixed, and WebDialogBrowserTest.SizeWindow
is enabled on Linux Aura.

The test is also enabled on Mac, but currently fails because
NativeViewHost isn't implemented yet. That's coming, and leaving the
test enabled will ensure we check it.

With this change browser_tests compiles and links on toolkit-views Mac.

BUG=404979, 399191, 52602
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290998

Review URL: https://codereview.chromium.org/486063002

Cr-Commit-Position: refs/heads/master@{#291272}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291272 0039d316-1c4b-4281-b951-d872f2087c98