• Rakina Zata Amni's avatar
    Fix browser expectation of "method" and "post_id" on same-document navigations · d80835ac
    Rakina Zata Amni authored
    Currently we use NavigationRequest's CommitNavigationParams' method in
    VerifyThatBrowserAndRendererCalculatedDidCommitParamsMatch, but that
    might differ than what the renderer returns on history same-document
    navigations due to the history API resetting methods to "GET".
    
    For POST ID, we use the last committed entry's POST ID on same-document
    navigations, but that will only work for main frame cases. We need to
    track the post ID directly in the RenderFrameHostImpl to cover cases
    with subframe navigations.
    
    This CL fixes the calculated values, and adds additional logging.
    
    Bug: 1155414
    Change-Id: I81358e641b7b3aaeda7fbcec58c92cef97ba9d27
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576878
    Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#835129}
    d80835ac
render_frame_host_impl.h 150 KB