• Toni Barzic's avatar
    Simplify how app list search box placeholder text is set · 026f9262
    Toni Barzic authored
    The search box placeholder text and accessible names for clamshell and
    tablet mode were being pushed from Chrome's app list client. Though,
    the strings do not depend on any Chrome state - the app list client just
    loads the strings when Chrome starts, and pushes them to the app list
    controller. It's much simpler to set the strings ash (similar to close
    and assistant button tooltips).
    
    Additionally, this ensures that the strings are retrieved when first
    needed. Given that the app list is first used in active user session,
    this should ensure that the string used is not using the default locale
    from when the profile is first created during user adding flow.
    
    Moves logic that tracks tablet mode state from SearchBoxViewBase to
    SearchBoxView class (given that SearchBoxView is the only specialization
    that cares about tablet mode state).
    
    Bug:1083787
    
    AX-Relnotes: n/a
    
    Change-Id: I867a699c36e42a2b9896f448c3e01645e526fcf9
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205979Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#769809}
    026f9262
example_app_list_client.cc 8.03 KB