• Peter Kasting's avatar
    Revert "Add Windows high contrast support to the toolbar button icons" · d9756248
    Peter Kasting authored
    This reverts commit 26a7b762.
    
    Reason for revert: Likely caused http://crbug.com/1049486
    
    Original change's description:
    > Add Windows high contrast support to the toolbar button icons
    > 
    > This change adds different foreground icon colors to the toolbar buttons
    > for the hovered and pressed states when the high contrast ink drop
    > feature is enabled. This is to support the desired platform high contrast
    > colors. Future work will add foreground color support to other buttons.
    > 
    > New theme properties were added to support the additional _HOVERED and
    > _PRESSED state high contrast colors. When not in high contrast, these
    > are the same as the normal icon color. In high contrast (+ flag) they
    > return the selected text HC color. These new colors are used to create
    > images in the toolbar buttons for the various button states.
    > 
    > New helper functions we added to ToolbarButton to simplify setting the
    > images for the different button states, including one that just uses
    > the standard colors returned by |GetForegroundColor|.
    > 
    > In the future, we might want to do work to allow icons to be separated
    > from colors to allow for easier recoloring.
    > 
    > Bug: 776871
    > Change-Id: Id72d8c60a23889f018044a5fcce7abd9359ad61a
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029492
    > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
    > Reviewed-by: Peter Kasting <pkasting@chromium.org>
    > Commit-Queue: Peter Kasting <pkasting@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#738660}
    
    TBR=pkasting@chromium.org,antrim@chromium.org,johnsm@microsoft.com,champnic@microsoft.com
    
    Change-Id: Ide6174254819728c271a3ed059cee7132cd2c124
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 776871
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040029Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#738863}
    d9756248
common_theme.cc 17.9 KB