• David Van Cleve's avatar
    fetch: Log net error codes for failed Trust Tokens operations · d9882f77
    David Van Cleve authored
    We're investigating some failed Trust tokens Issuance operations
    executed via the Fetch API. We previously landed logging to get a better
    understanding of why these fetches fail, but the logging groups together
    fetches that fail for a couple of distinct reasons that can make
    ResourceError::GetResourceRequestBlockedReason() return
    ResourceRequestBlockedReason::kOther:
    (1) Explicit ResourceRequestBlockedReason::kOther returns by logic in
    Blink
    (2) net::ERR_BLOCKED_BY_CLIENT and net::ERR_BLOCKED_BY_RESPONSE errors
    from downstream services that do *not* have associated
    network::mojom::BlockedByResponseReasons. (If they had associated
    BlockedByResponseReasons, these reasons would be mapped to
    non-kOther ResourceRequestBlockedReasons.)
    
    This CL adds some additional logging for failed Trust Tokens
    operation-bearing fetches' net errors, which will help resolve this
    particular ambiguity as well, in general, provide richer information
    than just the ResourceRequestBlockedReason.
    
    Bug: 1128174
    Change-Id: I84cd9e4f3551a364d1b80179a2c8f6b4085f8a8a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451729Reviewed-by: default avatarCharlie Harrison <csharrison@chromium.org>
    Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
    Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
    Commit-Queue: David Van Cleve <davidvc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#815351}
    d9882f77
histograms.xml 174 KB