• Nektarios Paisios's avatar
    Re-wrote boundary searching methods in AXPosition to work with offset boundaries · d9b457ed
    Nektarios Paisios authored
    This is the first patch resulting from splitting
    into multiple patches.
    
    The CreateBoundaryStartPosition and CreateBoundaryEndPosition methods
    were re-written to work with boundaries that are not only at the beginning
    or the end of specific nodes, but could also fall on a text offset
    *within* a node.
    
    This patch doesn't create any new publicly exposed functionality in AXPosition.
    
    Even though all existing tests should be passing unmodified,
    this patch has uncovered a bug on how we used to compute upstream affinity which has now been fixed.
    
    A followup patch will re-write word navigation functionality to use the above two methods.
    A second followup patch will introduce support for document markers in AXPosition.
    
    R=kschmi@microsoft.com, aleventhal@chromium.org, ethavar@microsoft.com
    
    https: //crrev.com/c/1874254/
    Bug: 1008031
    Change-Id: I1ed67028c950cda1226c3a1b9b732a8d5a2af036
    Change-Id: I1ed67028c950cda1226c3a1b9b732a8d5a2af036
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894159
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Reviewed-by: default avatarAaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: default avatarKurt Catti-Schmidt <kschmi@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#713509}
    d9b457ed
ax_node_position_unittest.cc 350 KB