• Elly Fong-Jones's avatar
    cbui: remove SharingDialogView CreateFootnoteView · da2bf7b5
    Elly Fong-Jones authored
    This change moves CreateFootnoteView into an anonymous namespace,
    and passes in the instance variables it needs. While the
    SharingDialogData member is not itself const, none of the members
    that CreateFootnoteView depends on change during the lifetime of
    SharingDialogView. Unfortunately the member cannot be const since
    it contains some callbacks that need to be run, and the members of
    SharingDialogData cannot be made const because they are iteratively
    filled in by other code before the dialog is created.
    
    Bug: 1011446
    Change-Id: I3af6a9a3d3c2e5aa2f1d50dbb560182ccff945c3
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901432Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#713433}
    da2bf7b5
sharing_dialog_view.cc 13.8 KB