• Maksim Moskvitin's avatar
    [TrustedVault] Move/remove Client unit tests · da99e30e
    Maksim Moskvitin authored
    StandaloneTrustedVaultClient is a plumbing class, that doesn't contain
    a lot of logic. Most of its test actually excersised
    StandaloneTrustedVaultBackend behavior (except
    ShouldPopulatePrimaryAccountChanges test).
    
    Incoming changes will make testing on the Client level more complicated
    and either requires extra changes in production code to allow mocking
    or making existing and future tests rather integration than unit. Since
    there are better ways to make integration tests and having unit tests
    on the Client level doesn't add much value, this CL:
    
    1. Removes ShouldPopulatePrimaryAccountChanges, because it has no
    reasonable way for testing otherwise and exercises minor amount of
    logic.
    
    2. Moves other tests to StandaloneTrustedVaultBackend level.
    
    Bug: 1102340
    Change-Id: I707e9d04f8e536f1de07f0bd27e3a216a242bc52
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436747
    Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#811800}
    da99e30e
BUILD.gn 22.1 KB