GitLab

Currently, partner bookmarks aren't submitted until all the favicons are
fetched which can potentially be quite slow on a bad connection. This
change submits the bookmarks after they're read, regardless of whether
the favicons have been fetched yet.

When all the asynchronous favicon fetching has completed, if any
favicons were retrieved from a server, we refresh the bookmarks to show
the new favicons.

Also adds a new enum value for FaviconFetchResult to capture the case
of retrieving a duplicate favicon that wasn't written to the favicon
image cache as a result of being duplicate. These were being treated as
the default FAILURE_SERVER_ERROR before, and blacklisting URLs
unnecessarily even when the favicon existed in the cache already.

Bug: 780042
Change-Id: I2409acc3c7c558106aae417d7e709fb0e7539f3f
Reviewed-on: https://chromium-review.googlesource.com/804655
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524508}