• Alex Turner's avatar
    Reland "Finish base::Bind -> Once/Repeating migration for media/blink and /cdm" · db1fc486
    Alex Turner authored
    This is a reland of 878c8c7d
    
    Reason for reland: media_blink_unittests should no longer be flaky after
    updating the condition in UpdateBackgroundVideoOptimzationState(). The
    flakiness derived from CancelableOnceCallback/Closure::IsCancelled()
    returning true after the callback is run.
    
    Original change's description:
    > Finish base::Bind -> Once/Repeating migration for media/blink and /cdm
    >
    > Use of base::Bind, ::Callback, etc. is deprecated in favor of the more
    > explicit Once/Repeating versions. Despite being marked as fixed, a few
    > directories have some remaining uses that were missed in the conversion.
    > This cl fixes those stragglers in the media/blink and media/cdm
    > directories. The presubmit is also enabled for these directories to
    > avoid any future regressions.
    >
    > Bug: 1141533, 1102651, 1007802
    > Change-Id: I0a58ba3165c1c8873a25de76065a7425495b62b1
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505580
    > Reviewed-by: Dirk Pranke <dpranke@google.com>
    > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
    > Commit-Queue: Alex Turner <alexmt@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#822344}
    
    Bug: 1141533
    Bug: 1102651
    Bug: 1007802
    Change-Id: Id1f87603ca9d41fe4fad91d6a7b389c889669fba
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508930
    Commit-Queue: Alex Turner <alexmt@chromium.org>
    Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
    Reviewed-by: default avatarChrome Cunningham <chcunningham@chromium.org>
    Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#838765}
    db1fc486
webmediaplayer_impl_unittest.cc 87.1 KB