• Hirokazu Honda's avatar
    GenericDmaBufVideoFrameValidator: Map YV12 VideoFrame as-is · db2bf675
    Hirokazu Honda authored
    GenericDmaBufVideoFrameValidator swaps U plane and V plane addresses so that
    VideoFrameValidator is able to libyuv::I420Copy in the order Y, U and V. This
    is a wrong design, meaning VideoFrameMapper does not only map but also
    does something. VideoFrameMapper caller should expect the address acquired by
    VideoFrame::data(UPlane) is V plane's and one by VideoFrame::data(VPlane) is U
    plane's in the case of YV12 VideoFrame.
    
    BUG=chromium:895230, chromium:856562
    TEST=VDA unittest on hana with --frame_validator=check
    TEST=VEA unittest on hana with --native_input
    
    Change-Id: Ibf5e5685d95634fe6720f07dc154fd01907516d8
    Reviewed-on: https://chromium-review.googlesource.com/c/1341783Reviewed-by: default avatarPawel Osciak <posciak@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#609518}
    db2bf675
generic_dmabuf_video_frame_mapper.cc 4.34 KB